upgrade(tracer): Support libdatadog's library_config module #5126

BaptisteFoy · 2025-01-17T14:58:33Z

What does this PR do?

Supports libdatadog's library_config module to configure the tracing libraries from a file on disk that may remotely managed.

We don't load the WASM module if the files don't exist on disk.

Motivation

Being able to configure tracing libraries from a file / the UI

Additional Notes

github-actions · 2025-01-17T14:59:13Z

Overall package size

Self size: 8.82 MB
Deduped: 95.42 MB
No deduping: 95.93 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

pr-commenter · 2025-01-17T15:07:53Z

Benchmarks

Benchmark execution time: 2025-02-28 15:08:25

Comparing candidate commit e30985d in PR branch baptiste.foy/FA/library-config-libdatadog with baseline commit 444ad14 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 916 metrics, 17 unstable metrics.

codecov · 2025-01-17T16:01:18Z

Codecov Report

Attention: Patch coverage is 90.10989% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.67%. Comparing base (444ad14) to head (e30985d).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
packages/dd-trace/src/config_stable.js	85.71%	8 Missing ⚠️
packages/dd-trace/src/config.js	96.77%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5126      +/-   ##
==========================================
+ Coverage   80.64%   80.67%   +0.02%     
==========================================
  Files         489      490       +1     
  Lines       21756    21836      +80     
==========================================
+ Hits        17546    17617      +71     
- Misses       4210     4219       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/dd-trace/src/config.js

datadog-datadog-prod-us1 · 2025-02-11T12:28:49Z

Datadog Report

Branch report: baptiste.foy/FA/library-config-libdatadog
Commit report: fc24b86
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 664 Passed, 0 Skipped, 10m 31.98s Total Time

szegedi

Mostly looks good, made some suggestions.

When @datadog/libdatadog gets released, add package.json and yarn.lock updates to this PR – I know you mentioned in the PR description that it needs to be done; I'm just emphasizing that it should be done as part of this PR.

packages/dd-trace/src/config.js

packages/dd-trace/src/config_stable.js

szegedi

We're getting there – looks mostly good, one more nit.

packages/dd-trace/src/config_stable.js

packages/dd-trace/src/config.js

rochdev · 2025-02-26T17:54:16Z

packages/dd-trace/src/config.js

-      : isFalse(profilingEnabledEnv)
-        ? 'false'
-        : profilingEnabledEnv === 'auto' ? 'auto' : undefined
+    const profilingEnabled = normalizeProfilingEnabledValue(profilingEnabledEnv)


profilingEnabledEnv is only used by profilingEnabled, should it be moved to the helper too? This would allow the helper to be used anywhere without having to know about the environment variables each time.

We can simplify the code a bit and remove profilingEnabledEnv as an intermediate variable. Though the input of normalizeProfilingEnabledValue isn't the same in the two places it's used (it's not an environment variable in stableConfig) so we can't do what you suggest.

rochdev · 2025-02-26T18:03:21Z

packages/dd-trace/src/config_stable.js

+    this.wasm_loaded = false
+
+    if (isInServerlessEnvironment()) {
+      // Bail out early if we're in a serverless environment, stable config isn't supported


This should be done before this file is ever loaded.

I tried something in don't load config_stable.js on serverless; please tell me if this what you expect.

I'm semi-convinced by my approach because it forces us to check whether or not the stableConfig object is defined at every call.

packages/dd-trace/src/config.js

packages/dd-trace/src/config_stable.js

khanayan123

No concerns on my end

BaptisteFoy force-pushed the baptiste.foy/FA/library-config-libdatadog branch from 852b817 to 83d4172 Compare January 17, 2025 15:35

rochdev reviewed Jan 31, 2025

View reviewed changes

packages/dd-trace/src/config.js Outdated Show resolved Hide resolved

packages/dd-trace/src/config.js Outdated Show resolved Hide resolved

BaptisteFoy force-pushed the baptiste.foy/FA/library-config-libdatadog branch 2 times, most recently from 369cde4 to d85addc Compare February 11, 2025 09:40

BaptisteFoy added the semver-minor label Feb 11, 2025

BaptisteFoy force-pushed the baptiste.foy/FA/library-config-libdatadog branch 2 times, most recently from d4e0a29 to f111eac Compare February 11, 2025 12:22

BaptisteFoy force-pushed the baptiste.foy/FA/library-config-libdatadog branch 4 times, most recently from 44e6e6f to 58d3ea2 Compare February 11, 2025 14:42

szegedi requested changes Feb 13, 2025

View reviewed changes

packages/dd-trace/src/config.js Outdated Show resolved Hide resolved

packages/dd-trace/src/config.js Outdated Show resolved Hide resolved

packages/dd-trace/src/config.js Outdated Show resolved Hide resolved

upgrade(tracer): Support libdatadog's library_config module

2bcf68f

BaptisteFoy force-pushed the baptiste.foy/FA/library-config-libdatadog branch 6 times, most recently from 923400e to 3361fe4 Compare February 20, 2025 10:33

address review

2a75923

BaptisteFoy force-pushed the baptiste.foy/FA/library-config-libdatadog branch 3 times, most recently from 34870a4 to a9071bf Compare February 20, 2025 12:38

temp

10eafd6

BaptisteFoy force-pushed the baptiste.foy/FA/library-config-libdatadog branch 2 times, most recently from baaddfe to 0b411d6 Compare February 20, 2025 13:07

szegedi requested changes Feb 21, 2025

View reviewed changes

packages/dd-trace/src/config.js Outdated Show resolved Hide resolved

packages/dd-trace/src/config_stable.js Show resolved Hide resolved

fix typo

71d478e

BaptisteFoy requested review from rochdev and szegedi February 21, 2025 17:21

szegedi requested changes Feb 25, 2025

View reviewed changes

packages/dd-trace/src/config_stable.js Outdated Show resolved Hide resolved

packages/dd-trace/src/config.js Show resolved Hide resolved

address review

7de0d2a

szegedi previously approved these changes Feb 25, 2025

View reviewed changes

BaptisteFoy dismissed szegedi’s stale review via 90b5ec4 February 26, 2025 15:37

Merge branch 'master' into baptiste.foy/FA/library-config-libdatadog

5beaa76

BaptisteFoy force-pushed the baptiste.foy/FA/library-config-libdatadog branch from 90b5ec4 to 5beaa76 Compare February 26, 2025 15:39

szegedi previously approved these changes Feb 26, 2025

View reviewed changes

rochdev requested changes Feb 26, 2025

View reviewed changes

BaptisteFoy added 2 commits February 27, 2025 10:50

address review

c17602a

don't load config_stable.js on serverless

1cbf8a5

BaptisteFoy dismissed szegedi’s stale review via 1cbf8a5 February 27, 2025 09:58

szegedi previously approved these changes Feb 27, 2025

View reviewed changes

fix lint

daed725

BaptisteFoy dismissed szegedi’s stale review via daed725 February 27, 2025 10:25

rochdev previously approved these changes Feb 28, 2025

View reviewed changes

Merge branch 'master' into baptiste.foy/FA/library-config-libdatadog

a2afd18

BaptisteFoy dismissed rochdev’s stale review via a2afd18 February 28, 2025 08:51

Merge branch 'master' into baptiste.foy/FA/library-config-libdatadog

e30985d

khanayan123 approved these changes Feb 28, 2025

View reviewed changes

szegedi approved these changes Mar 3, 2025

View reviewed changes

szegedi merged commit dcc7f48 into master Mar 3, 2025
396 checks passed

szegedi deleted the baptiste.foy/FA/library-config-libdatadog branch March 3, 2025 12:45

sabrenner pushed a commit that referenced this pull request Mar 4, 2025

Support Hand-Off Config (#5126)

776f68f

sabrenner mentioned this pull request Mar 4, 2025

v5.41.0 proposal #5361

Merged

sabrenner pushed a commit that referenced this pull request Mar 4, 2025

Support Hand-Off Config (#5126)

7b52c73

rochdev mentioned this pull request Mar 20, 2025

[BUG]: Datadog 5.41.0 causing high memory consumption #5394

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade(tracer): Support libdatadog's library_config module #5126

upgrade(tracer): Support libdatadog's library_config module #5126

BaptisteFoy commented Jan 17, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025 •

edited

Loading

pr-commenter bot commented Jan 17, 2025 •

edited

Loading

codecov bot commented Jan 17, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Feb 11, 2025 •

edited

Loading

szegedi left a comment

szegedi left a comment

rochdev Feb 26, 2025

BaptisteFoy Feb 27, 2025

rochdev Feb 26, 2025

BaptisteFoy Feb 27, 2025

khanayan123 left a comment

upgrade(tracer): Support libdatadog's library_config module #5126

upgrade(tracer): Support libdatadog's library_config module #5126

Conversation

BaptisteFoy commented Jan 17, 2025 • edited Loading

What does this PR do?

Motivation

Additional Notes

github-actions bot commented Jan 17, 2025 • edited Loading

Overall package size

pr-commenter bot commented Jan 17, 2025 • edited Loading

Benchmarks

codecov bot commented Jan 17, 2025 • edited Loading

Codecov Report

datadog-datadog-prod-us1 bot commented Feb 11, 2025 • edited Loading

Datadog Report

szegedi left a comment

Choose a reason for hiding this comment

szegedi left a comment

Choose a reason for hiding this comment

rochdev Feb 26, 2025

Choose a reason for hiding this comment

BaptisteFoy Feb 27, 2025

Choose a reason for hiding this comment

rochdev Feb 26, 2025

Choose a reason for hiding this comment

BaptisteFoy Feb 27, 2025

Choose a reason for hiding this comment

khanayan123 left a comment

Choose a reason for hiding this comment

BaptisteFoy commented Jan 17, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025 •

edited

Loading

pr-commenter bot commented Jan 17, 2025 •

edited

Loading

codecov bot commented Jan 17, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Feb 11, 2025 •

edited

Loading